[
https://issues.apache.org/jira/browse/HDFS-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077361#comment-17077361
]
Íñigo Goiri commented on HDFS-15261:
------------------------------------
Thanks [~ayushtkn] for the patch.
Some comments:
* In FederationMBean, let's unify the javadoc comments (adding periods at the
end, capitalize,...).
* In NamenodeHeartbeatService, let's extract that into a function or at least
create new vars for query and aux. There's a comment on refactor in that
function, this might be a good chance.
* Avoid the extra line at the end of the change in FederationProtocol.proto.
> RBF: Add Block Related Metrics
> ------------------------------
>
> Key: HDFS-15261
> URL: https://issues.apache.org/jira/browse/HDFS-15261
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15261-01.patch, HDFS-15261-02.patch
>
>
> Add Metrics Related to Blocks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
