[
https://issues.apache.org/jira/browse/HDFS-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081510#comment-17081510
]
Hadoop QA commented on HDFS-11927:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color}
| {color:red} HDFS-11927 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-11927 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12871593/HDFS-11927.002.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/29141/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> hdfs oiv_legacy:Normalize the verification of input parameter
> -------------------------------------------------------------
>
> Key: HDFS-11927
> URL: https://issues.apache.org/jira/browse/HDFS-11927
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 3.0.0-alpha3
> Reporter: LiXin Ge
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDFS-11927.002.patch, HDFS-11927.patch
>
>
> At present, hdfs oiv_legacy tool lacks in verification of input
> parameter.people can type in irrelevant option like:
> bq../hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML -step 1024
> or type in option with wrong format which he think come into effec but
> actually not:
> bq../hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p
> FileDistribution maxSize 4096 step 512 format
> or some meaningless word which can also get through:
> bq../hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML Hello World
> We'd better not let these cases go unchecked.
> By the way, this patch fixed some checkstyle warnings in
> +DelimitedImageVisitor.java+
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
