[
https://issues.apache.org/jira/browse/HDFS-15255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081677#comment-17081677
]
Lisheng Sun edited comment on HDFS-15255 at 4/15/20, 4:48 AM:
--------------------------------------------------------------
I confirmed again the failed UTs are not related to this jira.
FindBugs:
{code:java}
Call to
org.apache.hadoop.hdfs.protocol.DatanodeInfoWithStorage.equals(org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor)
in
org.apache.hadoop.hdfs.server.namenode.CacheManager.setCachedLocations(LocatedBlock)
At CacheManager.java: At CacheManager.java:[line 956]
Details
EC_UNRELATED_TYPES:
Call to equals() comparing different typesThis method calls equals(Object) on
two references of different class types and analysis suggests they will be to
objects of different classes at runtime. Further, examination of the equals
methods that would be invoked suggest that either this call will always return
false, or else the equals method is not be symmetric (which is a property
required by the contract for equals in class Object).{code}
i run the code by UT in my local successfully.
was (Author: leosun08):
I confirmed again the failed UTs are related to this jira.
FindBugs:
{code:java}
Call to
org.apache.hadoop.hdfs.protocol.DatanodeInfoWithStorage.equals(org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor)
in
org.apache.hadoop.hdfs.server.namenode.CacheManager.setCachedLocations(LocatedBlock)
At CacheManager.java: At CacheManager.java:[line 956]
Details
EC_UNRELATED_TYPES:
Call to equals() comparing different typesThis method calls equals(Object) on
two references of different class types and analysis suggests they will be to
objects of different classes at runtime. Further, examination of the equals
methods that would be invoked suggest that either this call will always return
false, or else the equals method is not be symmetric (which is a property
required by the contract for equals in class Object).{code}
i run the code by UT in my local successfully.
> Consider StorageType when DatanodeManager#sortLocatedBlock()
> ------------------------------------------------------------
>
> Key: HDFS-15255
> URL: https://issues.apache.org/jira/browse/HDFS-15255
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Lisheng Sun
> Assignee: Lisheng Sun
> Priority: Major
> Fix For: 3.4.0
>
> Attachments: HDFS-15255.001.patch, HDFS-15255.002.patch,
> HDFS-15255.003.patch, HDFS-15255.004.patch
>
>
> When only one replica of a block is SDD, the others are HDD.
> When the client reads the data, the current logic is that it considers the
> distance between the client and the dn. I think it should also consider the
> StorageType of the replica. Priority to return fast StorageType node when the
> distance is same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
