[
https://issues.apache.org/jira/browse/HDFS-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088079#comment-17088079
]
Chen Liang commented on HDFS-15287:
-----------------------------------
In case of roll back image, this check
{code}
NameNodeFile.IMAGE.equals(parsedParams.getNameNodeFile())
{code}
would make sure the rollback image is not subject to this check. Because in
case of rollback image, getNameNodeFile would return
{{NameNodeFile.IMAGE_ROLLBACK}} rather than {{NameNodeFile.IMAGE}}. So this
check should not apply to RU case at all.
In case of regular, periodic image upload though, I agree that the current
might be too stringent as there can be cases where ANN sees image with
potentially very minor time gap difference comparing to SBN. We recently also
have been thinking of relaxing this check. pinging [~shv].
> HDFS rollingupgrade prepare never finishes
> ------------------------------------------
>
> Key: HDFS-15287
> URL: https://issues.apache.org/jira/browse/HDFS-15287
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.10.0, 3.3.0
> Reporter: Kihwal Lee
> Priority: Blocker
>
> After HDFS-12979, the prepare step of rolling upgrade does not work. This is
> because it added additional check for sufficient time passing since last
> checkpoint. Since RU rollback image creation and upload can happen any time,
> uploading of rollback image never succeeds. For a new cluster deployed for
> testing, it might work since it never checkpointed before.
> It was found that this check is disabled for unit tests, defeating the very
> purpose of testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
