[ 
https://issues.apache.org/jira/browse/HDFS-15294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090407#comment-17090407
 ] 

Hadoop QA commented on HDFS-15294:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 29m 
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 9 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m  
4s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 
39s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 17m 
58s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  4m 
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 45s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
53s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  5m 
21s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
32s{color} | {color:blue} branch/hadoop-project no findbugs output file 
(findbugsXml.xml) {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
31s{color} | {color:blue} branch/hadoop-assemblies no findbugs output file 
(findbugsXml.xml) {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
31s{color} | {color:blue} branch/hadoop-tools/hadoop-tools-dist no findbugs 
output file (findbugsXml.xml) {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 17m 
16s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 17m 16s{color} 
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
2m 57s{color} | {color:orange} root: The patch generated 57 new + 0 unchanged - 
0 fixed = 57 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  5m 
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red}  0m  
0s{color} | {color:red} The patch generated 1 new + 0 unchanged - 0 fixed = 1 
total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 44s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
27s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
31s{color} | {color:blue} hadoop-project has no data from findbugs {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
31s{color} | {color:blue} hadoop-assemblies has no data from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
31s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs-rbf generated 9 new + 
0 unchanged - 0 fixed = 9 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  5m 
34s{color} | {color:red} hadoop-tools generated 3 new + 0 unchanged - 0 fixed = 
3 total (was 0) {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
34s{color} | {color:blue} hadoop-tools/hadoop-tools-dist has no data from 
findbugs {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
30s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green} hadoop-assemblies in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  8m 45s{color} 
| {color:red} hadoop-hdfs-rbf in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m 
54s{color} | {color:green} hadoop-federation-balance in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 63m 
40s{color} | {color:green} hadoop-tools in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
37s{color} | {color:green} hadoop-tools-dist in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
58s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}252m 43s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs-rbf |
|  |  org.apache.hadoop.hdfs.procedure.BalanceJob defines equals and uses 
Object.hashCode()  At BalanceJob.java:Object.hashCode()  At 
BalanceJob.java:[lines 288-303] |
|  |  org.apache.hadoop.hdfs.procedure.BalanceJob.NEXT_PROCEDURE_NONE isn't 
final but should be  At BalanceJob.java:be  At BalanceJob.java:[line 52] |
|  |  Possible null pointer dereference of BalanceJob.procedureTable in 
org.apache.hadoop.hdfs.procedure.BalanceJob.write(DataOutput)  Dereferenced at 
BalanceJob.java:BalanceJob.procedureTable in 
org.apache.hadoop.hdfs.procedure.BalanceJob.write(DataOutput)  Dereferenced at 
BalanceJob.java:[line 229] |
|  |  org.apache.hadoop.hdfs.procedure.BalanceJob.equals(Object) makes 
inefficient use of keySet iterator instead of entrySet iterator  At 
BalanceJob.java:keySet iterator instead of entrySet iterator  At 
BalanceJob.java:[line 297] |
|  |  org.apache.hadoop.hdfs.procedure.BalanceProcedure defines equals and uses 
Object.hashCode()  At BalanceProcedure.java:Object.hashCode()  At 
BalanceProcedure.java:[lines 128-133] |
|  |  org.apache.hadoop.hdfs.procedure.BalanceJob doesn't define a hashCode() 
method but is used in a hashed data structure in 
org.apache.hadoop.hdfs.procedure.BalanceProcedureScheduler.recoverAllJobs()  At 
BalanceProcedureScheduler.java:method but is used in a hashed data structure in 
org.apache.hadoop.hdfs.procedure.BalanceProcedureScheduler.recoverAllJobs()  At 
BalanceProcedureScheduler.java:[line 280] |
|  |  org.apache.hadoop.hdfs.procedure.BalanceProcedureScheduler$DelayWrapper 
defines compareTo(Object) and uses Object.equals()  At 
BalanceProcedureScheduler.java:Object.equals()  At 
BalanceProcedureScheduler.java:[line 368] |
|  |  Should 
org.apache.hadoop.hdfs.procedure.BalanceProcedureScheduler$DelayWrapper be a 
_static_ inner class?  At BalanceProcedureScheduler.java:inner class?  At 
BalanceProcedureScheduler.java:[lines 368-388] |
|  |  org.apache.hadoop.hdfs.server.federation.MountTableProcedure inherits 
equals and uses Object.hashCode()  At 
MountTableProcedure.java:Object.hashCode()  At MountTableProcedure.java:[lines 
54-162] |
| FindBugs | module:hadoop-tools |
|  |  Possible null pointer dereference of args in 
org.apache.hadoop.tools.DistCpFedBalance.run(String[])  Dereferenced at 
DistCpFedBalance.java:args in 
org.apache.hadoop.tools.DistCpFedBalance.run(String[])  Dereferenced at 
DistCpFedBalance.java:[line 66] |
|  |  org.apache.hadoop.tools.DistCpProcedure inherits equals and uses 
Object.hashCode()  At DistCpProcedure.java:Object.hashCode()  At 
DistCpProcedure.java:[lines 64-459] |
|  |  org.apache.hadoop.tools.TrashProcedure inherits equals and uses 
Object.hashCode()  At TrashProcedure.java:Object.hashCode()  At 
TrashProcedure.java:[lines 38-84] |
| Failed junit tests | hadoop.hdfs.procedure.TestBalanceProcedureScheduler |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/Dockerfile
 |
| JIRA Issue | HDFS-15294 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13000901/HDFS-15294.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite 
unit shadedclient xml findbugs checkstyle shellcheck shelldocs |
| uname | Linux 4b8883f25127 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 5958af4 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~16.04-b09 |
| compile | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/branch-compile-root.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/patch-compile-root.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/patch-compile-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/diff-checkstyle-root.txt
 |
| shellcheck | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/diff-patch-shellcheck.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/new-findbugs-hadoop-tools.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 3518 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-assemblies 
hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-tools/hadoop-federation-balance 
hadoop-tools hadoop-tools/hadoop-tools-dist U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29183/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.3.7 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> RBF: Balance data across federation namespaces with DistCp and snapshot diff
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-15294
>                 URL: https://issues.apache.org/jira/browse/HDFS-15294
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jinglun
>            Assignee: Jinglun
>            Priority: Major
>         Attachments: HDFS-15294.001.patch, HDFS-15294.002.patch, 
> distcp-balance.pdf
>
>
> This jira introduces a new balance command 'fedbalance' that is ran by the 
> administrator. The process is:
> 1. Use distcp and snapshot diff to sync data between src and dst until they 
> are the same.
> 2. Update mount table in Router.
> 3. Delete the src to trash.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to