[ 
https://issues.apache.org/jira/browse/HDFS-15293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091947#comment-17091947
 ] 

Konstantin Shvachko commented on HDFS-15293:
--------------------------------------------

 We should also incorporate the second condition for checkpointing - the 
transactions threshold. If somebody sets checkpoint interval ridiculously 
large, but rely solely on teh number of transactions for starting a checkpoint, 
the image will be rejected based on the time criteria.
I think the bast way is to refactor the checkpoint decision making into a 
{{CheckpointCondition}} class, which would maintain all the parameters and two 
main methods {{shouldStartCheckpoint()}} for StandbyNode, and 
{{shouldAcceptCheckpoint()}} for Active and Observers.

> Relax FSImage upload time delta check restriction
> -------------------------------------------------
>
>                 Key: HDFS-15293
>                 URL: https://issues.apache.org/jira/browse/HDFS-15293
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>              Labels: multi-sbnn
>
> HDFS-12979 introduced the logic that, if ANN sees consecutive fs image upload 
> from Standby with a small delta comparing to previous fsImage. ANN would 
> reject this image. This is to avoid overly frequent fsImage in case of when 
> there are multiple Standby node. However this check could be too stringent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to