[
https://issues.apache.org/jira/browse/HDFS-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096607#comment-17096607
]
Ayush Saxena commented on HDFS-15300:
-------------------------------------
Thanx [~xuzq_zander] for the patch and report, The overall patch looks good,
but I too feel we shouldn't move to {{NetUtils.createSocketAddr()}} in all
cases, If possible add an If check and move to this logic only once required.
if with that check, the code increases, you may refactor the logic to a new
method too as {{normalizeRpcAddress}} or something more relevant if required
and keep the main code straight as it is for better readability.
> RBF: updateActiveNamenode() is invalid when RPC address is IP
> -------------------------------------------------------------
>
> Key: HDFS-15300
> URL: https://issues.apache.org/jira/browse/HDFS-15300
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: xuzq
> Assignee: xuzq
> Priority: Major
> Attachments: HDFS-15300-001.patch
>
>
> ActiveNamenodeResolver#updateActiveNamenode will invalid when the rpc address
> like ip:port.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
