[
https://issues.apache.org/jira/browse/HDFS-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097056#comment-17097056
]
Tsz-wo Sze commented on HDFS-15313:
-----------------------------------
{code}
+ // TODO: Is it a bug to return true?
+ // Some ancestor nodes may not be in the latest snapshot.
{code}
Could you also file a JIRA?
+1 the 001 patch looks good.
> Ensure inodes in active filesytem are not deleted during snapshot delete
> ------------------------------------------------------------------------
>
> Key: HDFS-15313
> URL: https://issues.apache.org/jira/browse/HDFS-15313
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 3.4.0
>
> Attachments: HDFS-15313.000.patch, HDFS-15313.001.patch
>
>
> After HDFS-13101, it was observed in one of our customer deployments that
> delete snapshot ends up cleaning up inodes from active fs which can be
> referred from only one snapshot as the isLastReference() check for the parent
> dir introduced in HDFS-13101 may return true in certain cases. The aim of
> this Jira to add a check to ensure if the Inodes are being referred in the
> active fs , should not get deleted while deletion of snapshot happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
