[
https://issues.apache.org/jira/browse/HDFS-15255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098838#comment-17098838
]
Stephen O'Donnell commented on HDFS-15255:
------------------------------------------
[~leosun08] Patch 06 no longer applies to trunk, probably due to the other
change related to this we committed last week.
I asked some of my colleagues to check this find bug warnings, and they both
believed it can be ignored.
Before setting an ignore annotation on the code, one person suggested just
removing the equals (and also probably hashCode) from DatanodeInfoWithStorage.
All it does in both these methods is call super, and the normal inheritance
chain will do that anyway.
Could you try rebasing the 06 patch against trunk and then remove equals and
hashCode from DatanodeInfoWithStorage and lets see if that gets rid of the find
bugs warning?
> Consider StorageType when DatanodeManager#sortLocatedBlock()
> ------------------------------------------------------------
>
> Key: HDFS-15255
> URL: https://issues.apache.org/jira/browse/HDFS-15255
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Lisheng Sun
> Assignee: Lisheng Sun
> Priority: Major
> Fix For: 3.4.0
>
> Attachments: HDFS-15255-findbugs-test.001.patch,
> HDFS-15255.001.patch, HDFS-15255.002.patch, HDFS-15255.003.patch,
> HDFS-15255.004.patch, HDFS-15255.005.patch, HDFS-15255.006.patch,
> experiment-find-bugs.001.patch
>
>
> When only one replica of a block is SDD, the others are HDD.
> When the client reads the data, the current logic is that it considers the
> distance between the client and the dn. I think it should also consider the
> StorageType of the replica. Priority to return fast StorageType node when the
> distance is same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
