[ https://issues.apache.org/jira/browse/HDFS-15293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101307#comment-17101307 ]
Akira Ajisaka commented on HDFS-15293: -------------------------------------- Thank you [~shv] and [~vagarychen]. The change looks straightforward to me. Minor nits: * ImageServlet#setRecentImageCheckTimePrecision can be package-private. * MiniDFSCluster is AutoCloseable, so you can use try-with-resources in the test. I'm +1 if these are addressed. The test failures are not related to the patch. All the tests except TestBPOfferService passed on my local. TestBPOfferService: HDFS-15296 > Relax the condition for accepting a fsimage when receiving a checkpoint > ------------------------------------------------------------------------ > > Key: HDFS-15293 > URL: https://issues.apache.org/jira/browse/HDFS-15293 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Major > Labels: multi-sbnn > Attachments: HDFS-15293.001.patch > > > HDFS-12979 introduced the logic that, if ANN sees consecutive fs image upload > from Standby with a small delta comparing to previous fsImage. ANN would > reject this image. This is to avoid overly frequent fsImage in case of when > there are multiple Standby node. However this check could be too stringent. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org