[
https://issues.apache.org/jira/browse/HDFS-15340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106185#comment-17106185
]
Jinglun commented on HDFS-15340:
--------------------------------
Hi [~linyiqun], thanks your nice comments ! Upload v06.
{quote}We need verify more detail info of recovered job, like firstProcedure,
curProcedure and lastProcedure in this BalanceJob. This can completely check
that the job is correctly recovered.
So we should be make adjustment in {{BalanceJob#equal}}
{quote}
I think comparing job id, procedureTable and firstProcedure would be enough
because they are immutable. The other infos like curProcedure, lastProcedure
and jobDone change while the job runs. The initial job object might have
different curProcedure, lastProcedure and jobDone with the recovered job
object. But they are representing the same job.
So in v06 I only add firProcedure to the EqualsBuilder in BalanceJob#equal.
Let me know your thoughts.
> RBF: Implement BalanceProcedureScheduler basic framework
> --------------------------------------------------------
>
> Key: HDFS-15340
> URL: https://issues.apache.org/jira/browse/HDFS-15340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15340.001.patch, HDFS-15340.002.patch,
> HDFS-15340.003.patch, HDFS-15340.004.patch, HDFS-15340.005.patch,
> HDFS-15340.006.patch
>
>
> Patch in HDFS-15294 is too big to review so we split it into 2 patches. This
> is the first one. Detail can be found at HDFS-15294.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
