[
https://issues.apache.org/jira/browse/HDFS-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165035#comment-13165035
]
Suresh Srinivas commented on HDFS-2642:
---------------------------------------
Comments:
# DatanodeProtocolClientSideTranslatorPB.java
#* Please add javadoc for DatanodeProtocolClientSideTranslatorPB.
#* The RPC proxy creation is not consistent with DatanodeProtocolTranslatorR23
#* sendHeartbeat() is missing index++
#* blockReceivedAndDeleted() commitBlockSynchronization() has a line more than
80 columns
# DatanodeProtocolServerSideTranslatorPB.java
#* Please make some of the final members static. Also these lines are more than
80 columns. There are other lines (not imports) that exceed 80 columns as well.
#* Invalid protocol name used NamenodeProtocolPB.class
# Unnecessary change in NamenodeProtocolPB.java,
NamenodeProtocolTranslatorPB.java
# DatanodeProtocol.java change not necessary
> Protobuf translators for DatanodeProtocol
> -----------------------------------------
>
> Key: HDFS-2642
> URL: https://issues.apache.org/jira/browse/HDFS-2642
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-2642.trunk.patch
>
>
> This jira adds PB translators for DatanodeProtocol.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
