Rungroj Maipradit created HDFS-15361:
----------------------------------------

             Summary: Implement clear method in ErasureCodingPolicyManager class
                 Key: HDFS-15361
                 URL: https://issues.apache.org/jira/browse/HDFS-15361
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Rungroj Maipradit


In a research project, we analyzed the source code of Hadoop looking for 
comments with on-hold SATDs (self-admitted technical debt) that could be fixed 
already. An on-hold SATD is a TODO/FIXME comment blocked by an issue. If this 
blocking issue is already resolved, the related todo can be implemented (or 
sometimes it is already implemented, but the comment is left in the code 
causing confusions). As we found a few instances of these in HDFS, we decided 
to collect them in a ticket, so they are documented and can be addressed sooner 
or later.

Currently, the clear method of ErasureCodingPolicyManager class contains TODO 
with a code comment as a placeholder referencing HDFS-7337.
The comment still exists in trunk, while HDFS-7337 is already resolved as 
fixed. Yet, the clear method is not implemented.
{code:java}
// TODO: we should only clear policies loaded from NN metadata.
// This is a placeholder for HDFS-7337.
{code}
Comment location: 
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java#L287



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to