[ 
https://issues.apache.org/jira/browse/HDFS-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111247#comment-17111247
 ] 

Íñigo Goiri commented on HDFS-15288:
------------------------------------

Wow, that conf key length is something :)
Is there something we can do about that?

Minor comments:
* In the test use the static assert imports everywhere.
* In testChooseDataNode, no need to catch NPE to throw an assertion failure. If 
there is an exception, that should fail directly.
* If we are converting the [0,1] to 0 to 100 in the code, why not just pass 0 
to 100 which is usually more intuitive?
* Can you add an explanation to what 0 and 1 (or 100 now) do?

> Add Available Space Rack Fault Tolerant BPP
> -------------------------------------------
>
>                 Key: HDFS-15288
>                 URL: https://issues.apache.org/jira/browse/HDFS-15288
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-15288-01.patch, HDFS-15288-02.patch
>
>
> The Present {{AvailableSpaceBlockPlacementPolicy}} extends the Default Block 
> Placement policy, which makes it apt for Replicated files. But not very 
> efficient for EC files, which by default use. 
> {{BlockPlacementPolicyRackFaultTolerant}}. So propose a to add new BPP having 
> similar optimization as ASBPP where as keeping the spread of Blocks to max 
> racks, i.e as RackFaultTolerantBPP.
> This could extend {{BlockPlacementPolicyRackFaultTolerant}}, rather than the 
> {{BlockPlacementPOlicyDefault}} like ASBPP and keep other logics of 
> optimization same as ASBPP



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to