[ 
https://issues.apache.org/jira/browse/HDFS-15364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112054#comment-17112054
 ] 

Hadoop QA commented on HDFS-15364:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} markdownlint {color} | {color:blue}  0m  
0s{color} | {color:blue} markdownlint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 
 5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 57s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  2m 
50s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
48s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 42s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch 
generated 18 new + 65 unchanged - 4 fixed = 83 total (was 69) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 44s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 10s{color} 
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
40s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 58s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup |
|   | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-HDFS-Build/29340/artifact/out/Dockerfile
 |
| JIRA Issue | HDFS-15364 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13003480/HDFS-15364.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite 
unit shadedclient findbugs checkstyle markdownlint |
| uname | Linux fccc63450b7e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / cef07569294 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29340/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29340/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29340/testReport/ |
| Max. process+thread count | 4100 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/29340/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Support sort the output according to the number of occurrences of the opcode 
> for StatisticsEditsVisitor
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-15364
>                 URL: https://issues.apache.org/jira/browse/HDFS-15364
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: tools
>    Affects Versions: 3.2.1
>            Reporter: bianqi
>            Assignee: bianqi
>            Priority: Minor
>         Attachments: HDFS-15364.001.patch, HDFS-15364.002.patch
>
>
>       At present, when we execute `hdfs oev -p stats -i edits -o 
> edits.stats`, the output format is as follows, and all the opcodes will be 
> output once.
> {quote}VERSION : -65
>  OP_ADD ( 0): 2
>  OP_RENAME_OLD ( 1): 2
>  OP_DELETE ( 2): 0
>  OP_MKDIR ( 3): 5
>  OP_SET_REPLICATION ( 4): 0
>  OP_DATANODE_ADD ( 5): 0
>  OP_DATANODE_REMOVE ( 6): 0
>  OP_SET_PERMISSIONS ( 7): 4
>  OP_SET_OWNER ( 8): 1
>  OP_CLOSE ( 9): 2
>  OP_SET_GENSTAMP_V1 ( 10): 0
>  OP_SET_NS_QUOTA ( 11): 0
>  OP_CLEAR_NS_QUOTA ( 12): 0
>  OP_TIMES ( 13): 0
>  OP_SET_QUOTA ( 14): 0
>  OP_RENAME ( 15): 0
>  OP_CONCAT_DELETE ( 16): 0
>  OP_SYMLINK ( 17): 0
>  OP_GET_DELEGATION_TOKEN ( 18): 0
>  OP_RENEW_DELEGATION_TOKEN ( 19): 0
>  OP_CANCEL_DELEGATION_TOKEN ( 20): 0
>  OP_UPDATE_MASTER_KEY ( 21): 0
>  OP_REASSIGN_LEASE ( 22): 0
>  OP_END_LOG_SEGMENT ( 23): 1
>  OP_START_LOG_SEGMENT ( 24): 1
>  OP_UPDATE_BLOCKS ( 25): 0
>  OP_CREATE_SNAPSHOT ( 26): 0
>  OP_DELETE_SNAPSHOT ( 27): 0
>  OP_RENAME_SNAPSHOT ( 28): 0
>  OP_ALLOW_SNAPSHOT ( 29): 0
>  OP_DISALLOW_SNAPSHOT ( 30): 0
>  OP_SET_GENSTAMP_V2 ( 31): 2
>  OP_ALLOCATE_BLOCK_ID ( 32): 2
>  OP_ADD_BLOCK ( 33): 2
>  OP_ADD_CACHE_DIRECTIVE ( 34): 0
>  OP_REMOVE_CACHE_DIRECTIVE ( 35): 0
>  OP_ADD_CACHE_POOL ( 36): 0
>  OP_MODIFY_CACHE_POOL ( 37): 0
>  OP_REMOVE_CACHE_POOL ( 38): 0
>  OP_MODIFY_CACHE_DIRECTIVE ( 39): 0
>  OP_SET_ACL ( 40): 0
>  OP_ROLLING_UPGRADE_START ( 41): 0
>  OP_ROLLING_UPGRADE_FINALIZE ( 42): 0
>  OP_SET_XATTR ( 43): 0
>  OP_REMOVE_XATTR ( 44): 0
>  OP_SET_STORAGE_POLICY ( 45): 0
>  OP_TRUNCATE ( 46): 0
>  OP_APPEND ( 47): 0
>  OP_SET_QUOTA_BY_STORAGETYPE ( 48): 0
>  OP_ADD_ERASURE_CODING_POLICY ( 49): 0
>  OP_ENABLE_ERASURE_CODING_POLIC ( 50): 0
>  OP_DISABLE_ERASURE_CODING_POLI ( 51): 0
>  OP_REMOVE_ERASURE_CODING_POLIC ( 52): 0
>  OP_INVALID ( -1): 0
> {quote}
>  But in general, the edits file we parse does not involve all the operation 
> codes. If all the operation codes are output, it is unfriendly for the 
> cluster administrator to view the output.
>     we usually only care about what opcodes appear in the edits file.We can 
> output the opcodes that appeared in the edits file and sort them.
> For example, we can execute the following command:
> {quote} hdfs oev -p stats -i edits_0000000000000001321-0000000000000001344 
> -sort -o edits.stats -v
> {quote}
> The output format is as follows:
> {quote}VERSION : -65
>  OP_MKDIR ( 3): 5
>  OP_SET_PERMISSIONS ( 7): 4
>  OP_ADD ( 0): 2
>  OP_RENAME_OLD ( 1): 2
>  OP_CLOSE ( 9): 2
>  OP_SET_GENSTAMP_V2 ( 31): 2
>  OP_ALLOCATE_BLOCK_ID ( 32): 2
>  OP_ADD_BLOCK ( 33): 2
>  OP_SET_OWNER ( 8): 1
>  OP_END_LOG_SEGMENT ( 23): 1
>  OP_START_LOG_SEGMENT ( 24): 1
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to