[
https://issues.apache.org/jira/browse/HDFS-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165632#comment-13165632
]
Todd Lipcon commented on HDFS-2634:
-----------------------------------
bq. The precondition in recoverUnclosedStreams should check that isOpenForWrite
for true right?
It would be {{isOpenForWrite() && !isSegmentOpen()}}. I thought it was clearer
to specifically reference the one valid state here ({{BETWEEN_LOG_SEGMENTS}}.
bq. Preconditions eg of form checkState(state == State.BETWEEN_LOG_SEGMENTS)
can be checkState(isSegmentOpen()).
I fixed a couple of these - the others were the same situation as above.
Running some tests now, will attach new patch momentarily.
> Standby needs to ingest latest edit logs before transitioning to active`
> ------------------------------------------------------------------------
>
> Key: HDFS-2634
> URL: https://issues.apache.org/jira/browse/HDFS-2634
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hdfs-2634.txt
>
>
> When the standby transitions to active state, it needs to _read_ the latest
> edit logs before it reopens them for write access. Currently, the transition
> calls {{stopStandbyServices}}, which stops the tailer, but doesn't read ahead
> to the very end. This ends up leaving the shared edits dir in an inconsistent
> state where we have overlapping transaction IDs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
