[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120112#comment-17120112
]
Yiqun Lin commented on HDFS-15346:
----------------------------------
Hi [~LiJinglun], thanks for updating the patch, seems a very big patch :D.
I do a quick glance for the patch, some high level comments from me:
* Can we make fedbalance tool for the normal federation mode rather than RBF
mode by default? RBF is a new feature, normal federation mode should be more
common.
* For the moving to trash behavior, I suggest we can additional add one option
to not delete source data. So the option moveToTrash will have following 3
sub-options:
{noformat}
* do nothing and let users do cleanup work. Sometimes, users want to hold
off the data for few days in case there are some files needed re-copied.
* move to trash (default way)
* directly delete source data files (not recommended way).
{noformat}
* We can have an option to specified delay time duration for procedure. This
can avoid some frequency check and trigger retry procedures. For some large
fedbalance copy, we need the large delay time to do re-check.
* Can we move Balance procedure related classes to this new module that we
implemented in HDFS-15340 ? This same tool code should be combined in the same
module. That will looks good.
> RBF: Balance data across federation namespaces with DistCp and snapshot diff
> / Step 2: The DistCpFedBalance.
> ------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-15346
> URL: https://issues.apache.org/jira/browse/HDFS-15346
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15346.001.patch, HDFS-15346.002.patch,
> HDFS-15346.003.patch, HDFS-15346.004.patch
>
>
> Patch in HDFS-15294 is too big to review so we split it into 2 patches. This
> is the second one. Detail can be found at HDFS-15294.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
