[ 
https://issues.apache.org/jira/browse/HDFS-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126178#comment-17126178
 ] 

Ayush Saxena edited comment on HDFS-15321 at 6/4/20, 8:59 PM:
--------------------------------------------------------------

A {{FileSystem.closeAll();}} in the {{tearDown()}} of the 
{{TestDFSAdminWithHA}} fixes the test for me.
But we should fix this in DFSAdmin itself.
The reason of failure I feels now is : now {{FileSystem}} is not being stored 
as part of {{FsShell#fs}}
So, when close is called for DFSAdmin, The close method of parent {{FsShell}} 
is called which tends to close the {{FileSystem}}, since {{fs}} is not stored 
now, the FileSystem doesn't get closed.

We should make sure the {{FileSystem}} is closed when {{DFSAdmin}} is closed.
I think we can even store it also like previously rather than everytime calling 
{{AdminHelper.getDFS(getConf())}} whenever {{getDFS()}} is called, if there is 
no specific reason for eliminating it now


was (Author: ayushtkn):
A {{FileSystem.closeAll();}} in the {{tearDown()}} of the 
{{TestDFSAdminWithHA}} fixes the test for me.

> Make DFSAdmin tool to work with ViewFSOverloadScheme
> ----------------------------------------------------
>
>                 Key: HDFS-15321
>                 URL: https://issues.apache.org/jira/browse/HDFS-15321
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: dfsadmin, fs, viewfs
>    Affects Versions: 3.2.1
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Major
>
> When we enable ViewFSOverLoadScheme and used hdfs scheme as overloaded 
> scheme, users work with hdfs uris. But here DFSAdmin expects the impl classe 
> to be DistribbuteFileSystem. If impl class is ViewFSoverloadScheme, it will 
> fail.
> So, when impl is ViewFSoverloadScheme, we should get corresponding child hdfs 
> to make DFSAdmin to work.
> This Jira makes the DFSAdmin to work with ViewFSoverloadScheme.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to