[
https://issues.apache.org/jira/browse/HDFS-15374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140990#comment-17140990
]
Yiqun Lin commented on HDFS-15374:
----------------------------------
[~LiJinglun], thanks for updating the patch!
Minor comments from me:
{code:java}
Finally when the source and the target are the same, it
+ updates the mount table in Router and moves the source to trash.
{code}
It will better to mention in the normal federation mode and in the rbf mode..
{code:java}
In normal federation mode the source path must includes the source cluster.
{code}
This can update to
{code:java}
In normal federation mode the source path must includes the path schema.
{code}
I have a question here, can we support the full path like
hdfs://my-ns01/src-folder instead of above specific nn port address now? In the
local config, we often have the nn address configured in the hdfs-site.xml
The name {{DistCpFedBalance}} should be updated to FedBalance in doc since it
has been renamed now,
Some whitespaces I find, please remove these redundant whitespaces which leads
checkstyles warnings.
{noformat}
+ This will scan the journal to find all the unfinished jobs, recover and
+ continue to execute them.
+ <--- whitespaces
+ If we want to balance in a normal federation cluster, use the command below.
+
+ bash$ /bin/hadoop fedbalance submit hdfs://nn0:8020/foo/src
hdfs://nn1:8020/foo/dst
+<--- whitespaces
+ In normal federation mode the source path must includes the source cluster.
+
+### RBF Mode And Normal Federation Mode
+
+ The federation balance tool has 2 modes: <---whitespaces
+<---whitespaces
+ * the router-based federation mode (RBF mode).
+ * the normal federation mode.
+<---whitespaces
+ By default the command runs in the normal federation mode. You can specify
the
+ rbf mode by using the option `-router`.
+<---whitespaces
+ In the rbf mode the first parameter is taken as the mount point. It disables
+ write by setting the mount point readonly.
+<---whitespaces
+ In the normal federation mode the first parameter is taken as the full path
of
+ the source. The first parameter must include the source cluster. It disables
+ write by cancelling all the permissions of the source path.
+<---whitespaces
+ Details about disabling write see [DistCpFedBalance](#DistCpFedBalance).
...
when there is no diff and no open files. <---whitespaces
+ * FINAL_DISTCP: Force close all the open files and submit the final distcp.
+ * FINISH: Do the cleanup works. In normal federation mode the finish stage
+ also restores the permission of the dst path.
+ <----whitespaces
+ * MountTableProcedure: This procedure updates the mount entry in Router. The
<---whitespaces
+ readonly is unset and the destination is updated of the mount point. This
{noformat}
I don't see the picture file that contained in the patch.
For the picture attached in the patch, we can use git diff --binary option to
generate the patch that contains binary files.
Sample:
{noformat}
git add files...
git diff --cached --binary > your patch name
{noformat}
> Add documentation for fedbalance tool
> -------------------------------------
>
> Key: HDFS-15374
> URL: https://issues.apache.org/jira/browse/HDFS-15374
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: BalanceProcedureScheduler.png, HDFS-15374.001.patch,
> HDFS-15374.002.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
