[ 
https://issues.apache.org/jira/browse/HDFS-15404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144249#comment-17144249
 ] 

Chen Liang commented on HDFS-15404:
-----------------------------------

Thanks for checking [~shv]! These three test might slipped through my previous 
local testing somehow. Updated with v03 patch to fix these tests. On high 
level, the fixes are:
1. some cases mock fencing with a null target HA state, which was treated as 
illegal state by this new change.
2. in the new fencing logic, for a successful failover, two tryFence gets 
called, no longer just one; for a failed failover, if fail happens on fencing 
target, fencing on source will be skipped. TestFailoverController needs to be 
changed to reflect this new logic. 

> ShellCommandFencer should expose info about source
> --------------------------------------------------
>
>                 Key: HDFS-15404
>                 URL: https://issues.apache.org/jira/browse/HDFS-15404
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>         Attachments: HDFS-15404.001.patch, HDFS-15404.002.patch, 
> HDFS-15404.003.patch
>
>
> Currently the HA fencing logic in ShellCommandFencer exposes environment 
> variable about only the fencing target. i.e. the $target_* variables as 
> mentioned in this [document 
> page|https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HDFSHighAvailabilityWithQJM.html]).
>  
> But here only the fencing target variables are getting exposed. Sometimes it 
> is useful to expose info about the fencing source node. One use case is would 
> allow source and target node to identify themselves separately and run 
> different commands/scripts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to