[
https://issues.apache.org/jira/browse/HDFS-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146113#comment-17146113
]
Akira Ajisaka commented on HDFS-15421:
--------------------------------------
Thanks [~shv] for your comment.
{quote}
2. I think adding applyImpendingGenerationStamp() in OP_REASSIGN_LEASE is
incorrect as it restores the race condition of HDFS-14941.
{quote}
Agreed. We should not update the SNN global genstamp in {{OP_REASSIGN_LEASE}}.
The global genstamp will be updated when tailing {{OP_CLOSE}} or other
operations after {{OP_REASSIGN_LEASE}}.
{quote}
3. Found one more place FSEditLogLoader.addNewBlock() were we need to add
setGenerationStampIfGreater(). addNewBlock() adds a block with a new genStamp.
{quote}
Already covered in HDFS-14941:
https://github.com/apache/hadoop/blob/dd900259c421d6edd0b89a535a1fe08ada91735f/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java#L4742
Now I'm +1 for 004 patch.
> IBR leak causes standby NN to be stuck in safe mode
> ---------------------------------------------------
>
> Key: HDFS-15421
> URL: https://issues.apache.org/jira/browse/HDFS-15421
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Kihwal Lee
> Assignee: Akira Ajisaka
> Priority: Blocker
> Labels: release-blocker
> Attachments: HDFS-15421-000.patch, HDFS-15421-001.patch,
> HDFS-15421.002.patch, HDFS-15421.003.patch, HDFS-15421.004.patch,
> HDFS-15421.005.patch, HDFS-15421.006.patch, HDFS-15421.007.patch
>
>
> After HDFS-14941, update of the global gen stamp is delayed in certain
> situations. This makes the last set of incremental block reports from append
> "from future", which causes it to be simply re-queued to the pending DN
> message queue, rather than processed to complete the block. The last set of
> IBRs will leak and never cleaned until it transitions to active. The size of
> {{pendingDNMessages}} constantly grows until then.
> If a leak happens while in a startup safe mode, the namenode will never be
> able to come out of safe mode on its own.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
