[ 
https://issues.apache.org/jira/browse/HDFS-15448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152972#comment-17152972
 ] 

Íñigo Goiri commented on HDFS-15448:
------------------------------------

[~hexiaoqiao] already went through the code paths.
We may want to add a check to createDataNode() and runDatanodeDaemon() to 
verify that the block manager is started.
I would make sure that the tests for createDataNode() checks for something like 
testBPServiceState().

> When starting a DataNode, call BlockPoolManager#startAll() twice.
> -----------------------------------------------------------------
>
>                 Key: HDFS-15448
>                 URL: https://issues.apache.org/jira/browse/HDFS-15448
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.1.1
>            Reporter: jianghua zhu
>            Assignee: jianghua zhu
>            Priority: Major
>         Attachments: HDFS-15448.001.patch, HDFS-15448.002.patch, 
> method_invoke_path.jpg
>
>
> When starting a DataNode, call BlockPoolManager#startAll() twice.
> The first call:
> BlockPoolManager#doRefreshNamenodes()
> private void doRefreshNamenodes(
>  Map<String, Map<String, InetSocketAddress>> addrMap,
>  Map<String, Map<String, InetSocketAddress>> lifelineAddrMap)
>  throws IOException {
>  ...
> startAll();
> ...
> }
> The second call:
> DataNode#runDatanodeDaemon()
> public void runDatanodeDaemon() throws IOException {
> blockPoolManager.startAll();
> ...
> }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to