[ 
https://issues.apache.org/jira/browse/HDFS-15479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161319#comment-17161319
 ] 

Shashikant Banerjee commented on HDFS-15479:
--------------------------------------------

Thanks [~szetszwo] for working on this. The changes look ok .
{code:java}
final Snapshot earliest = snapshottable.getSnapshotList().get(0);
{code}
I think the snapshot list is sorted by name and the 1st element in the list may 
not be the earliest snapshot ? can you plz check?

> Ordered snapshot deletion: make it a configurable feature
> ---------------------------------------------------------
>
>                 Key: HDFS-15479
>                 URL: https://issues.apache.org/jira/browse/HDFS-15479
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: snapshots
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>         Attachments: h15479_20200719.patch
>
>
> Ordered snapshot deletion is a configurable feature.  In this JIRA, a conf is 
> added.
> When the feature is enabled, only the earliest snapshot can be deleted.  For 
> deleting the non-earliest snapshots, the behavior is temporarily changed to 
> throwing an exception in this JIRA.  In HDFS-15480, the behavior of deleting 
> the non-earliest snapshots will be changed to marking them as deleted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to