[
https://issues.apache.org/jira/browse/HDFS-15480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161927#comment-17161927
]
Mukul Kumar Singh commented on HDFS-15480:
------------------------------------------
Thanks for the patch [~shashikant]. Some comments as following.
a) FSDirSnapshotOp:280, Lets use the FSDirXAttrOp.unprotectedSetXAttrs api
and lets assert that the Snapshot Xattr is only set on Snapshot root.
b) TestOrderedSnapshotDeletion:105, lets also assert that the value should be
null/non-existent
c) TestOrderedSnapshotDeletion:152, can use the same name creation api as in
FSDirSnapshotOp. This will keep the name in test consistent.
> Ordered snapshot deletion: record snapshot deletion in XAttr
> ------------------------------------------------------------
>
> Key: HDFS-15480
> URL: https://issues.apache.org/jira/browse/HDFS-15480
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: snapshots
> Reporter: Tsz-wo Sze
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDFS-15480.000.patch, HDFS-15480.001.patch
>
>
> In this JIRA, the behavior of deleting the non-earliest snapshots will be
> changed to marking them as deleted in XAttr but not actually deleting them.
> Note that
> # The marked-for-deletion snapshots will be garbage collected later on; see
> HDFS-15481.
> # The marked-for-deletion snapshots will be hided from users; see HDFS-15482.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
