[ 
https://issues.apache.org/jira/browse/HDFS-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162986#comment-17162986
 ] 

Hemanth Boyina commented on HDFS-12969:
---------------------------------------

thanks [~tasanuma] for the review 
{quote}TestDecommission#testListOpenFilesWithType failed when 
{{dfs.namenode.list.openfiles.num.responses}} is not 1 (like 2 or 3). Some 
BLOCKING_DECOMMISSION files are incorrectly listed as ALL_OPEN_FILES
{quote}
updated the patch by adding a new test case for different number of responses
{quote} I think NameNode needs to have the list of ALL_OPEN_FILES(non-blocking) 
files in advance
{quote}
agree that , having this will make the improvement easier , but i think 
Namenode having all openfiles without blocking decommission  in advance will 
not be benefited/useful in our current scenarios except listOpenFilesByType

 

> DfsAdmin listOpenFiles should report files by type
> --------------------------------------------------
>
>                 Key: HDFS-12969
>                 URL: https://issues.apache.org/jira/browse/HDFS-12969
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.1.0
>            Reporter: Manoj Govindassamy
>            Assignee: Hemanth Boyina
>            Priority: Major
>         Attachments: HDFS-12969.001.patch, HDFS-12969.002.patch, 
> HDFS-12969.003.patch
>
>
> HDFS-11847 has introduced a new option to {{-blockingDecommission}} to an 
> existing command 
> {{dfsadmin -listOpenFiles}}. But the reporting done by the command doesn't 
> differentiate the files based on the type (like blocking decommission). In 
> order to change the reporting style, the proto format used for the base 
> command has to be updated to carry additional fields and better be done in a 
> new jira outside of HDFS-11847. This jira is to track the end-to-end 
> enhancements needed for dfsadmin -listOpenFiles console output.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to