[ 
https://issues.apache.org/jira/browse/HDFS-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163808#comment-17163808
 ] 

Hemanth Boyina commented on HDFS-15473:
---------------------------------------

thanks for the review [~weichiu]
{quote}We don't have a counter for total number snapshots
{quote}
numSnapshots in SnapshotManager could give the total number of snapshots
{quote}Ideally, you want to use an iterator to return partial results instead 
of returning all in an array
{quote}
yes , iterator will be more beneficial here , But NN dont have list for 
snapshots, so adding a TreeMap in Snapshot Manager should be fine ?

 

> Add listSnapshots command to list all snapshots
> -----------------------------------------------
>
>                 Key: HDFS-15473
>                 URL: https://issues.apache.org/jira/browse/HDFS-15473
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Hemanth Boyina
>            Assignee: Hemanth Boyina
>            Priority: Major
>         Attachments: HDFS-15473.001.patch
>
>
> In a cluster where snapshots are highly used , it will benefit to have a 
> command to list all the snapshots under root



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to