[ https://issues.apache.org/jira/browse/HDFS-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HDFS-2646: ------------------------------------- Attachment: HDFS-2646.patch The attached patch fixes 2 of the findbug issues. The following findbug issues are false positives: {code} UL org.apache.hadoop.lib.service.instrumentation.InstrumentationService.getToAdd(String, String, Class, Lock, Map) does not release lock on all paths ST Write to static field org.apache.hadoop.fs.http.server.HttpFSServerWebApp.SERVER from instance method org.apache.hadoop.fs.http.server.HttpFSServerWebApp.destroy() {code} The first one may be due to the fact that if/else logic is too complex for findbug to follow. The second one, the HttpFSServerWebApp() class is effectively a singleton in the WebApp, thus assignment of a static var in an instance method is OK. The attached patch bumps up the findbug count for these 2 false positives. > Hadoop HttpFS introduced 4 findbug warnings. > -------------------------------------------- > > Key: HDFS-2646 > URL: https://issues.apache.org/jira/browse/HDFS-2646 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.24.0, 0.23.1 > Reporter: Uma Maheswara Rao G > Assignee: Alejandro Abdelnur > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2646.patch > > > https://builds.apache.org/job/PreCommit-HDFS-Build/1665//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs-httpfs.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira