[ 
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180741#comment-17180741
 ] 

Íñigo Goiri commented on HDFS-15535:
------------------------------------

Thanks [~ayushtkn] for  [^HDFS-15535-06.patch], this integrates much better.
I have the feeling that we should do:
{code}
@SuppressWarnings("unchecked")          
T ret = (T)result;
return new RemoteResult<T, R>(loc, ret);
{code}

Then to avoid churn, can we leave loc as loc instead of using the new 
invokedLocation var?

> RBF: Fix Namespace path to snapshot path resolution for snapshot API
> --------------------------------------------------------------------
>
>                 Key: HDFS-15535
>                 URL: https://issues.apache.org/jira/browse/HDFS-15535
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-15535-01.patch, HDFS-15535-02.patch, 
> HDFS-15535-03.patch, HDFS-15535-04.patch, HDFS-15535-05.patch, 
> HDFS-15535-06.patch
>
>
> Presently, after invoking {{createSnapshot}} and {{getSnapshotListing}}, the 
> namespace path is replaced with mount path.
>  This presumes as of now that, the invokedLocation shall always be the first 
> one in the sequence, but there are multiple reasons, where the directory 
> might not be in the first location.
>  So, rather than replacing using firstLocation, we should replace path using 
> actual invoked Location.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to