[
https://issues.apache.org/jira/browse/HDFS-15546?focusedWorklogId=475917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475917
]
ASF GitHub Bot logged work on HDFS-15546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Aug/20 17:31
Start Date: 28/Aug/20 17:31
Worklog Time Spent: 10m
Work Description: jianghuazhu closed pull request #2256:
URL: https://github.com/apache/hadoop/pull/2256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 475917)
Time Spent: 1.5h (was: 1h 20m)
> Remove duplicate initializeGenericKeys method when creating
> DFSZKFailoverController
> -----------------------------------------------------------------------------------
>
> Key: HDFS-15546
> URL: https://issues.apache.org/jira/browse/HDFS-15546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: jianghua zhu
> Assignee: jianghua zhu
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.0
>
> Attachments: HDFS-15546.001.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When calling the DFSZKFailoverController#create() method, call
> NameNode#initializeGenericKeys() twice.
> First call:
> DFSZKFailoverController#create() {
> ...
> NameNode.initializeGenericKeys(localNNConf, nsId, nnId);
> ...
> }
> The second call:
> NNHAServiceTarget construction method:
> NNHAServiceTarget() {
> ...
> NameNode.initializeGenericKeys(targetConf, nsId, nnId);
> ...
> }
> In fact, the parameters passed in the two calls are the same. Here you can
> remove the first call without affecting the program itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
