[
https://issues.apache.org/jira/browse/HDFS-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Collins updated HDFS-2654:
------------------------------
Attachment: hdfs-2654-b1-4.patch
bq. prefer to rename it to RemoteBlockReader instead of BlockReaderRemote
Done.
bq. what's the reason to add this new closeStream method in addition to
close(), instead of just making the BlockReader interface extend Closeable?
That's better. Made BlockReader extend Closeable and removed closeStream (by
having BlockReader#close call IOUtils#closeStream on both streams instead of
using IOUtils#closeStream(reader) to do this.
> Make BlockReaderLocal not extend RemoteBlockReader2
> ---------------------------------------------------
>
> Key: HDFS-2654
> URL: https://issues.apache.org/jira/browse/HDFS-2654
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.1, 1.0.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-2654-1.patch, hdfs-2654-2.patch, hdfs-2654-2.patch,
> hdfs-2654-2.patch, hdfs-2654-3.patch, hdfs-2654-b1-1.patch,
> hdfs-2654-b1-2.patch, hdfs-2654-b1-3.patch, hdfs-2654-b1-4.patch
>
>
> The BlockReaderLocal code paths are easier to understand (especially true on
> branch-1 where BlockReaderLocal inherits code from BlockerReader and
> FSInputChecker) if the local and remote block reader implementations are
> independent, and they're not really sharing much code anyway. If for some
> reason they start to share sifnificant code we can make the BlockReader
> interface an abstract class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
