[ https://issues.apache.org/jira/browse/HDFS-15565?focusedWorklogId=480919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480919 ]
ASF GitHub Bot logged work on HDFS-15565: ----------------------------------------- Author: ASF GitHub Bot Created on: 09/Sep/20 16:43 Start Date: 09/Sep/20 16:43 Worklog Time Spent: 10m Work Description: sunchao commented on a change in pull request #2292: URL: https://github.com/apache/hadoop/pull/2292#discussion_r485763717 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java ########## @@ -705,7 +705,6 @@ static private int doBalance(Collection<URI> namenodes, LOG.info("excluded nodes = " + p.getExcludedNodes()); LOG.info("source nodes = " + p.getSourceNodes()); checkKeytabAndInit(conf); - System.out.println("Time Stamp Iteration# Bytes Already Moved Bytes Left To Move Bytes Being Moved"); Review comment: Hmm why you think this is not valid? I thought this is the header line for the balancer progress. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 480919) Time Spent: 0.5h (was: 20m) > Remove the invalid code in the Balancer#doBalance() method. > ----------------------------------------------------------- > > Key: HDFS-15565 > URL: https://issues.apache.org/jira/browse/HDFS-15565 > Project: Hadoop HDFS > Issue Type: Improvement > Components: balancer & mover > Reporter: jianghua zhu > Assignee: jianghua zhu > Priority: Major > Labels: pull-request-available > Fix For: 3.3.0 > > Attachments: HDFS-15565.001.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > In the Balancer#doBalance() method, an invalid line of code is added, as > follows: > static private int doBalance(Collection<URI> namenodes, > Collection<String> nsIds, final BalancerParameters p, Configuration conf) > throws IOException, InterruptedException > { ... System.out.println("Time Stamp Iteration# Bytes Already Moved Bytes > Left To Move Bytes Being Moved"); ... } > > I think it was originally used for testing. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org