[ 
https://issues.apache.org/jira/browse/HDFS-15025?focusedWorklogId=481836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481836
 ]

ASF GitHub Bot logged work on HDFS-15025:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Sep/20 01:12
            Start Date: 11/Sep/20 01:12
    Worklog Time Spent: 10m 
      Work Description: YaYun-Wang commented on a change in pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#discussion_r486716471



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/StorageType.java
##########
@@ -34,28 +34,35 @@
 @InterfaceStability.Unstable
 public enum StorageType {
   // sorted by the speed of the storage types, from fast to slow
-  RAM_DISK(true),
-  SSD(false),
-  DISK(false),
-  ARCHIVE(false),
-  PROVIDED(false);
+  RAM_DISK(true, true),
+  NVDIMM(false, true),
+  SSD(false, false),
+  DISK(false, false),
+  ARCHIVE(false, false),
+  PROVIDED(false, false);
 
   private final boolean isTransient;
+  private final boolean isRAM;
 
   public static final StorageType DEFAULT = DISK;
 
   public static final StorageType[] EMPTY_ARRAY = {};
 
   private static final StorageType[] VALUES = values();
 
-  StorageType(boolean isTransient) {
+  StorageType(boolean isTransient, boolean isRAM) {
     this.isTransient = isTransient;
+    this.isRAM = isRAM;
   }
 
   public boolean isTransient() {
     return isTransient;
   }
 
+  public boolean isRAM() {
+    return isRAM;
+  }

Review comment:
       > My final query then, why can't have one NVDIMM like one SSD as this 
also movable and peristent..?
   
   
   Considering NVDIMM is faster, so NVDIMM does not  use `FsDatasetCache()` 
which SSD needs in the design.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 481836)
    Time Spent: 4h  (was: 3h 50m)

> Applying NVDIMM storage media to HDFS
> -------------------------------------
>
>                 Key: HDFS-15025
>                 URL: https://issues.apache.org/jira/browse/HDFS-15025
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode, hdfs
>            Reporter: YaYun Wang
>            Assignee: YaYun Wang
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: Applying NVDIMM to HDFS.pdf, HDFS-15025.001.patch, 
> HDFS-15025.002.patch, HDFS-15025.003.patch, HDFS-15025.004.patch, 
> HDFS-15025.005.patch, HDFS-15025.006.patch, NVDIMM_patch(WIP).patch
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> The non-volatile memory NVDIMM is faster than SSD, it can be used 
> simultaneously with RAM, DISK, SSD. The data of HDFS stored directly on 
> NVDIMM can not only improves the response rate of HDFS, but also ensure the 
> reliability of the data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to