[
https://issues.apache.org/jira/browse/HDFS-14815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194019#comment-17194019
]
Ayush Saxena commented on HDFS-14815:
-------------------------------------
By using the filesystem object, when you were setting quota, was that staying
up? [~LiJinglun] said it wasn't. So, is there a change in functionality, NO,
then we just prevented communicating the user that things worked and prevented
him from an illusion.
If it was staying up, First comes is a design issue, What permissions are being
checked the one at RouterAdmin or the destination, I think, in this case would
be destination? Then the mount entry belongs to router admin, changes to it
should check its permission? Something to think.
But yes, if it was staying up(I couldn't follow the discussion again) and there
were no permission/security issue, then that might land up being an
incompatible change, else Not.
For eg: if on setting quota the user was getting twice the quota if there were
two NS, now he gets only from One. It changed the CLI output, and changing CLI
output is an incompatible change. But with the above logic, I won't put this as
well in the incompatible category.
Second: For non-mount entries in present code, if you set quota as 10, and
there are 2 NS, it earlier use to show 20 and follow as well 20, Now it shows
10, follows 20, Changed CLI output, Is that incompatible? That is something I
don't know.
> RBF: Update the quota in MountTable when calling setQuota on a MountTable src.
> ------------------------------------------------------------------------------
>
> Key: HDFS-14815
> URL: https://issues.apache.org/jira/browse/HDFS-14815
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HDFS-14815.001.patch, HDFS-14815.002.patch,
> HDFS-14815.003.patch, HDFS-14815.004.patch, HDFS-14815.005.patch
>
>
> The method setQuota() can make the remote quota(the quota on real clusters)
> inconsistent with the MountTable. I think we have 3 ways to fix it:
> # Reject all the setQuota() rpcs if it trys to change the quota of a mount
> table.
> # Let setQuota() to change the mount table quota. Update the quota on zk
> first and then update remote quotas.
> # Do nothing. The RouterQuotaUpdateService will finally make all the remote
> quota right. We can tolerate short-term inconsistencies.
> I'd like option 1 because I want the RouterAdmin to be the only entrance to
> update the MountTable.
> Option 3 we don't need change anything, but the quota will be inconsistent
> for a short-term. The remote quota will be effective immediately and
> auto-changed back after a while. User might be confused about the behavior.
> Â
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
