[
https://issues.apache.org/jira/browse/HDFS-15539?focusedWorklogId=481924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481924
]
ASF GitHub Bot logged work on HDFS-15539:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/20 06:52
Start Date: 11/Sep/20 06:52
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2258:
URL: https://github.com/apache/hadoop/pull/2258#issuecomment-690911942
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 3m 33s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 6m 17s | root in trunk failed. |
| -1 :x: | compile | 0m 26s | hadoop-hdfs-project in trunk failed with
JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | compile | 0m 25s | hadoop-hdfs-project in trunk failed with
JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -0 :warning: | checkstyle | 0m 23s | The patch fails to run
checkstyle in hadoop-hdfs-project |
| -1 :x: | mvnsite | 0m 17s | hadoop-hdfs-client in trunk failed. |
| +1 :green_heart: | shadedclient | 3m 6s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 51s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 2m 19s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 3m 4s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 7m 1s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 18s | the patch passed |
| -1 :x: | compile | 6m 7s | hadoop-hdfs-project in the patch failed
with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | javac | 6m 7s | hadoop-hdfs-project in the patch failed
with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | compile | 0m 22s | hadoop-hdfs-project in the patch failed
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -1 :x: | javac | 0m 22s | hadoop-hdfs-project in the patch failed
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -0 :warning: | checkstyle | 0m 23s | The patch fails to run
checkstyle in hadoop-hdfs-project |
| -1 :x: | mvnsite | 0m 26s | hadoop-hdfs-client in the patch failed. |
| -1 :x: | mvnsite | 0m 25s | hadoop-hdfs in the patch failed. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace
issues. |
| +1 :green_heart: | shadedclient | 0m 25s | patch has no errors when
building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 25s | hadoop-hdfs-client in the patch failed
with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | javadoc | 0m 27s | hadoop-hdfs in the patch failed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | javadoc | 0m 23s | hadoop-hdfs in the patch failed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -1 :x: | findbugs | 0m 28s | hadoop-hdfs-client in the patch failed.
|
| -1 :x: | findbugs | 0m 30s | hadoop-hdfs in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 11s | hadoop-hdfs-client in the patch
passed. |
| -1 :x: | unit | 129m 33s | hadoop-hdfs in the patch passed. |
| -1 :x: | asflicense | 0m 33s | The patch generated 4 ASF License
warnings. |
| | | 179m 16s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.security.TestPermissionSymlinks |
| | hadoop.fs.permission.TestStickyBit |
| | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
| | hadoop.hdfs.TestGetFileChecksum |
| | hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs |
| | hadoop.hdfs.TestFileChecksumCompositeCrc |
| | hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs |
| | hadoop.hdfs.TestFileChecksum |
| | hadoop.security.TestRefreshUserMappings |
| | hadoop.hdfs.TestReadStripedFileWithMissingBlocks |
| | hadoop.tools.TestJMXGet |
| | hadoop.hdfs.server.namenode.ha.TestHAAppend |
| | hadoop.security.TestPermission |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2258 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 3158e5f6446b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 9960c01a25c |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| mvninstall |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| compile |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/buildtool-branch-checkstyle-hadoop-hdfs-project.txt
|
| mvnsite |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| compile |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| compile |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/buildtool-patch-checkstyle-hadoop-hdfs-project.txt
|
| mvnsite |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| mvnsite |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/testReport/ |
| asflicense |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 3074 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client
hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 481924)
Time Spent: 1h 20m (was: 1h 10m)
> When disallowing snapshot on a dir, throw exception if its trash root is not
> empty
> ----------------------------------------------------------------------------------
>
> Key: HDFS-15539
> URL: https://issues.apache.org/jira/browse/HDFS-15539
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When snapshot is disallowed on a dir, {{getTrashRoots()}} won't return the
> trash root in that dir anymore (if any). The risk is the trash root will be
> left there forever.
> We need to throw an exception there and prompt the user to clean up or rename
> the trash root if it is not empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]