[
https://issues.apache.org/jira/browse/HDFS-1558?focusedWorklogId=484537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484537
]
ASF GitHub Bot logged work on HDFS-1558:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/20 14:42
Start Date: 15/Sep/20 14:42
Worklog Time Spent: 10m
Work Description: ayushtkn commented on pull request #2305:
URL: https://github.com/apache/hadoop/pull/2305#issuecomment-692761784
Thanx @umamaheswararao for the fix, I just had a very quick look.
Just want to confirm, In rename, do we need to avoid any scenario like
HDFS-15444? Or that is guarded already.
Secondly, In resolve result, can we change the constructor directly?, or do
we need to have an overloaded constructor to avoid compatibility issues, that
might have saved couple of changes as well.
The PR title has the wrong jira id, the last digit got missed. Do correct
it, before pushing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 484537)
Time Spent: 20m (was: 10m)
> Optimize FSNamesystem.startFileInternal
> ---------------------------------------
>
> Key: HDFS-1558
> URL: https://issues.apache.org/jira/browse/HDFS-1558
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode, performance
> Reporter: Dmytro Molkov
> Assignee: Dmytro Molkov
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently on file creation inside of FSNamesystem.startFileInternal there are
> three calls to FSDirectory that are essentially the same:
> dir.exists(src)
> dir.isDir(src)
> dir.getFileInode(src)
> All of them have to fetch the inode and then do some processing on it.
> If instead we were to fetch the inode once and then do all of the processing
> on this INode object it would save us two trips through the namespace + 2
> calls to normalizePath all of which are relatively expensive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
