[ 
https://issues.apache.org/jira/browse/HDFS-15516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199142#comment-17199142
 ] 

Ayush Saxena commented on HDFS-15516:
-------------------------------------

Thanx [~jianghuazhu] for the v005 patch,

{code:java}
+      logAuditEvent(true, operationName + " (options=" + flag + ")", srcArg);
{code}
I think, you are changing the operation name here, It would be having the 
options appended to it's name. Which can break parsers relying on 
{{.equals(operation)}}
So, I don't think you can do this way. What I think can be done is, you can add 
one more field in the end and put these options in that rather than changing 
the command name.


> Add info for create flags in NameNode audit logs
> ------------------------------------------------
>
>                 Key: HDFS-15516
>                 URL: https://issues.apache.org/jira/browse/HDFS-15516
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Shashikant Banerjee
>            Assignee: jianghua zhu
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HDFS-15516.001.patch, HDFS-15516.002.patch, 
> HDFS-15516.003.patch, HDFS-15516.004.patch, HDFS-15516.005.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently, if file create happens with flags like overwrite , the audit logs 
> doesn't seem to contain the info regarding the flags in the audit logs. It 
> would be useful to add info regarding the create options in the audit logs 
> similar to Rename ops. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to