[
https://issues.apache.org/jira/browse/HDFS-15025?focusedWorklogId=488112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488112
]
ASF GitHub Bot logged work on HDFS-15025:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/20 09:32
Start Date: 22/Sep/20 09:32
Worklog Time Spent: 10m
Work Description: YaYun-Wang commented on a change in pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#discussion_r492598805
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsVolumeList.java
##########
@@ -202,6 +205,14 @@ public void testDfsReservedForDifferentStorageTypes()
throws IOException {
.setConf(conf)
.build();
assertEquals("", 100L, volume4.getReserved());
+ FsVolumeImpl volume5 = new FsVolumeImplBuilder().setDataset(dataset)
+ .setStorageDirectory(
+ new StorageDirectory(
+ StorageLocation.parse("[NVDIMM]"+volDir.getPath())))
+ .setStorageID("storage-id")
+ .setConf(conf)
+ .build();
+ assertEquals("", 3L, volume5.getReserved());
Review comment:
In order to be consistent with the original code, the `assertEquals()`
here has three parameters, such as, lines 196 and 204 of the original code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 488112)
Time Spent: 7.5h (was: 7h 20m)
> Applying NVDIMM storage media to HDFS
> -------------------------------------
>
> Key: HDFS-15025
> URL: https://issues.apache.org/jira/browse/HDFS-15025
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode, hdfs
> Reporter: YaYun Wang
> Assignee: YaYun Wang
> Priority: Major
> Labels: pull-request-available
> Attachments: Applying NVDIMM to HDFS.pdf, HDFS-15025.001.patch,
> HDFS-15025.002.patch, HDFS-15025.003.patch, HDFS-15025.004.patch,
> HDFS-15025.005.patch, HDFS-15025.006.patch, NVDIMM_patch(WIP).patch
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> The non-volatile memory NVDIMM is faster than SSD, it can be used
> simultaneously with RAM, DISK, SSD. The data of HDFS stored directly on
> NVDIMM can not only improves the response rate of HDFS, but also ensure the
> reliability of the data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
