[ 
https://issues.apache.org/jira/browse/HDFS-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202843#comment-17202843
 ] 

Ayush Saxena commented on HDFS-15591:
-------------------------------------

Thanx [~wangzhaohui] for the patch. The fix seems correct.
Minor comments :
* Avoid empty line change at L847
* 
{code:java}
-  private HdfsFileStatus getMountPointStatus(
+  public HdfsFileStatus getMountPointStatus(
{code}
Default access shall work? Add {{VisibleForTesting}}
* 
{code:java}
+    assertEquals("testC", dirStatus.getLocalName());
{code}
Use {{child}} instead of {{"testC"}} and similarly for the other two assertions 
below
* Give a check to the checkstyle warnings



> RBF: Fix webHdfs file display error
> -----------------------------------
>
>                 Key: HDFS-15591
>                 URL: https://issues.apache.org/jira/browse/HDFS-15591
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: wangzhaohui
>            Assignee: wangzhaohui
>            Priority: Major
>         Attachments: HDFS-15591-001.patch, HDFS-15591-002.patch, 
> HDFS-15591-003.patch, RBF_Browse_Directory.png, after-1.jpg, after-2.jpg, 
> before-1.jpg, before-2.jpg
>
>
> The path mounted by the router does not exist on NN,router will  create 
> virtual folder with the mount name, but the "browse the file syaytem" display 
> on http is wrong. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to