[ 
https://issues.apache.org/jira/browse/HDFS-15614?focusedWorklogId=497468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497468
 ]

ASF GitHub Bot logged work on HDFS-15614:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/20 17:40
            Start Date: 08/Oct/20 17:40
    Worklog Time Spent: 10m 
      Work Description: smengcl opened a new pull request #2370:
URL: https://github.com/apache/hadoop/pull/2370


   https://issues.apache.org/jira/browse/HDFS-15614
   
   Added `checkAndProvisionSnapshotTrashRoots` in `FSNamesystem`. Triggered in 
`NameNode` on startup if `dfs.namenode.snapshot.trashroot.enabled` set to 
`true`.
   
   UT added in `TestDistributedFileSystem`.
   
   The logic is ready for review.
   I am considering adding another UT for HA case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 497468)
    Remaining Estimate: 0h
            Time Spent: 10m

> Initialize snapshot trash root during NameNode startup if enabled
> -----------------------------------------------------------------
>
>                 Key: HDFS-15614
>                 URL: https://issues.apache.org/jira/browse/HDFS-15614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is a follow-up to HDFS-15607.
> Goal:
> Initialize (create) snapshot trash root for all existing snapshottable 
> directories if {{dfs.namenode.snapshot.trashroot.enabled}} is set to 
> {{true}}. So admins won't have to run {{dfsadmin -provisionTrash}} manually 
> on all those existing snapshottable directories.
> The change is expected to land in {{FSNamesystem}}.
> Discussion:
> 1. Currently in HDFS-15607, the snapshot trash root creation logic is on the 
> client side. But in order for NN to create it at startup, the logic must 
> (also) be implemented on the server side as well. -- which is also a 
> requirement by WebHDFS (HDFS-15612).
> 2. Alternatively, we can provide an extra parameter to the 
> {{-provisionTrash}} command like: {{dfsadmin -provisionTrash -all}} to 
> initialize/provision trash root on all existing snapshottable dirs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to