[ 
https://issues.apache.org/jira/browse/HDFS-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210499#comment-17210499
 ] 

Chen Liang commented on HDFS-15567:
-----------------------------------

Thanks for working on this [~shv]! Some comments:

1. Currently calling {{AbstractFileSystem.java}}'s msync throws 
UnsupportedOperationException, I was thinking whether it should be throwing 
UnsupportedOperationException, or just making it a noop. (similarly for 
{{FileSystem.java}}'s msync}}. I think making it noop might be better, any 
thoughts?
 2. Change in {{MiniDFSCluster.java}}, is it really needed?
 3. testMsyncFileContext has a LOG info call, seems unnecessary. Also looks 
like it only test FileContext, should we also test for FileSystem?

> [SBN Read] HDFS should expose msync() API to allow downstream applications 
> call it explicetly.
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-15567
>                 URL: https://issues.apache.org/jira/browse/HDFS-15567
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ha, hdfs-client
>    Affects Versions: 2.10.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Major
>         Attachments: HDFS-15567.001.patch, HDFS-15567.002.patch
>
>
> Consistent reads from Standby introduced {{msync()}} API HDFS-13688, which 
> updates client's state ID with current state of the Active NameNode to 
> guarantee consistency of subsequent calls to an ObserverNode. Currently this 
> API is exposed via {{DFSClient}} only, which makes it hard for applications 
> to access {{msync()}}. One way is to use something like this:
> {code}
> if(fs instanceof DistributedFileSystem) {
>   ((DistributedFileSystem)fs).getClient().msync();
> }
> {code}
> This should be exposed both for {{FileSystem}} and {{FileContext}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to