[ 
https://issues.apache.org/jira/browse/HDFS-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217248#comment-17217248
 ] 

Chengwei Wang commented on HDFS-15630:
--------------------------------------

[~elgoiri], thanks for your comment.

I think that split appendClientIpToCallerContext()  into two functions maybe 
better. We should check whether the context contains current client ip info 
first, and then add client ip info to context if needed. What do you think?

 

> RBF: Fix wrong client IP info in CallerContext when requests mount points 
> with multi-destinations.
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-15630
>                 URL: https://issues.apache.org/jira/browse/HDFS-15630
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: Chengwei Wang
>            Assignee: Chengwei Wang
>            Priority: Major
>         Attachments: HDFS-15630.001.patch, HDFS-15630.002.patch, 
> HDFS-15630.003.patch, HDFS-15630.004.patch, HDFS-15630.test.patch
>
>
> There are two issues about client IP info in CallerContext when we try to 
> request mount points with multi-destinations.
>  # the clientIp would duplicate in CallerContext when 
> RouterRpcClient#invokeSequential.
>  # the clientIp would miss in CallerContext when 
> RouterRpcClient#invokeConcurrent. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to