[ https://issues.apache.org/jira/browse/HDFS-15641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219656#comment-17219656 ]
Hui Fei edited comment on HDFS-15641 at 10/23/20, 12:46 PM: ------------------------------------------------------------ [~wanghongbing] Sorry, i miss the changes of BPOfferService.java and run the UT, so it passes. {code:java} 1. lifelineSender.start(); 2. bpThread.start(); {code} If the order of execution is 1, then 2. *lifelineSender.start()* runs before *bpThread.run()*, It will not have dead lock. But if the order of execution is 2, then 1. *bpThread.run()* and *lifelineSender.start()* could run concurrently, and the it could have dead lock here. Is it right ? Minor comments: I found TestRefreshNamenodes.java, could you please move your UT there? was (Author: ferhui): [~wanghongbing] Sorry, i miss the changes of BPOfferService.java and run the UT, so it passes. * 1. lifelineSender.start(); * 2. bpThread.start(); If the order of execution is 1, then 2. *lifelineSender.start()* runs before *bpThread.run()*, It will not have dead lock. But if the order of execution is 2, then 1. *bpThread.run()* and *lifelineSender.start()* could run concurrently, and the it could have dead lock here. Is it right ? Minor comments: I found TestRefreshNamenodes.java, could you please move your UT there? > DataNode could meet deadlock if invoke refreshNameNode > ------------------------------------------------------ > > Key: HDFS-15641 > URL: https://issues.apache.org/jira/browse/HDFS-15641 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.2.0 > Reporter: Hongbing Wang > Assignee: Hongbing Wang > Priority: Critical > Attachments: HDFS-15641.001.patch, HDFS-15641.002.patch, > deadlock.png, deadlock_fixed.png, jstack.log > > > DataNode could meet deadlock when invoke `hdfs dfsadmin -refreshNamenodes > hostname:50020` to register a new namespace in federation env. > The jstack is shown in jstack.log > The specific process is shown in Figure deadlock.png -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org