[ 
https://issues.apache.org/jira/browse/HDFS-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169676#comment-13169676
 ] 

Hadoop QA commented on HDFS-2335:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12507392/HDFS-2335.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 90 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  
org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
                  
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
                  org.apache.hadoop.hdfs.TestListFilesInFileContext
                  org.apache.hadoop.hdfs.TestListFilesInDFS

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1714//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1714//console

This message is automatically generated.
                
> DataNodeCluster and NNStorage always pull fresh entropy
> -------------------------------------------------------
>
>                 Key: HDFS-2335
>                 URL: https://issues.apache.org/jira/browse/HDFS-2335
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, name-node
>            Reporter: Eli Collins
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2335.patch
>
>
> Jira for giving DataNodeCluster and NNStorage the same treatment as 
> HDFS-1835. They're not truly cryptographic uses as well. We should also 
> factor this out to a utility method, seems like the three uses are slightly 
> different, eg one uses DFSUtil.getRandom and the other creates a new Random 
> object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to