[
https://issues.apache.org/jira/browse/HDFS-15659?focusedWorklogId=508525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508525
]
ASF GitHub Bot logged work on HDFS-15659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/20 16:23
Start Date: 06/Nov/20 16:23
Worklog Time Spent: 10m
Work Description: ayushtkn commented on pull request #2435:
URL: https://github.com/apache/hadoop/pull/2435#issuecomment-723169619
This change actually is leading to a lot of changes, though that is
straightforward, but touching all the testcases....I think I have hard feelings
for it(Folks would bug us, if that test fails for any other reason too). If in
any case we want to go with the present approach I think other folks should
also consider these many changes necessary. More over most of the people would
not know or care to bother they have to use new configuration that you have
introduced and they would directly spawn up a MiniDfsCluster, Thus in long run
we might land up at the same problem, and again we have to to do this same
exercise.
If we just enable it in `MiniDfsCluster`, the change would be minimal and we
can provide a flag, if enabled the config won't be bothered. I won't say the
current approach is wrong in any way. It is completely correct, there can be
multiple ways to do one thing. Just that I prefer keeping it in
`MiniDfsCluster`, That was something the Jira tittle also......
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 508525)
Time Spent: 1h 20m (was: 1h 10m)
> Set dfs.namenode.redundancy.considerLoad to false in MiniDFSCluster
> -------------------------------------------------------------------
>
> Key: HDFS-15659
> URL: https://issues.apache.org/jira/browse/HDFS-15659
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Akira Ajisaka
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> dfs.namenode.redundancy.considerLoad is true by default and it is causing
> many test failures. Let's disable it in MiniDFSCluster.
> Originally reported by [~weichiu]:
> https://github.com/apache/hadoop/pull/2410#pullrequestreview-516144442
> {quote}
> i've certain seen this option causing test failures in the past.
> Maybe we should turn it off by default in MiniDDFSCluster, and only enable it
> for specific tests.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
