[
https://issues.apache.org/jira/browse/HDFS-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229546#comment-17229546
]
Simbarashe Dzinamarira commented on HDFS-15623:
-----------------------------------------------
[~shv], [~hchaverri]
Could we throw an exception if *RPC.setProtocolEngine()* is called for a
configuration that has already been set? Just from the function name it is not
clear to a user that *RPC.setProtocolEngine()* only works on the first
invocation. The javadoc helps but we may need an "if and only if". Even then a
user may not check the documentation.
> Respect configured values of rpc.engine
> ---------------------------------------
>
> Key: HDFS-15623
> URL: https://issues.apache.org/jira/browse/HDFS-15623
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Hector Sandoval Chaverri
> Assignee: Hector Sandoval Chaverri
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.1, 3.4.0, 3.1.5, 2.10.2, 3.2.3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The HDFS Configuration allows users to specify the RPCEngine implementation
> to use when communicating with Datanodes and Namenodes. However, the value is
> overwritten to ProtobufRpcEngine.class in different classes. As an example in
> NameNodeRpcServer:
> {{RPC.setProtocolEngine(conf, ClientNamenodeProtocolPB.class,
> ProtobufRpcEngine.class);}}
> {{The configured value of rpc.engine.[protocolName] should be respected to
> allow for other implementations of RPCEngine to be used}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
