[
https://issues.apache.org/jira/browse/HDFS-15689?focusedWorklogId=516374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516374
]
ASF GitHub Bot logged work on HDFS-15689:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/20 22:41
Start Date: 24/Nov/20 22:41
Worklog Time Spent: 10m
Work Description: smengcl commented on pull request #2472:
URL: https://github.com/apache/hadoop/pull/2472#issuecomment-733275478
> Thanks @smengcl . I think, we will run into the same problem while
creating an encryption zone on a snapshottable dir and may need a similar fix
there. Can you plz check?
The reverse won't be a problem because encryption zone can only be created
on empty directories.
Once snapshot is enabled (`dfs.namenode.snapshot.trashroot.enabled=true),
`.Trash` will prevent encryption zone to be enabled on that directory unless
the admin manually removes it and then do it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 516374)
Time Spent: 2h (was: 1h 50m)
> allow/disallowSnapshot on EZ roots shouldn't fail due to trash
> provisioning/emptiness check
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-15689
> URL: https://issues.apache.org/jira/browse/HDFS-15689
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Affects Versions: 3.4.0
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> h2. Background
> 1. HDFS-15607 added a feature that when
> {{dfs.namenode.snapshot.trashroot.enabled=true}}, allowSnapshot will
> automatically create a .Trash directory immediately after allowSnapshot
> operation so files deleted will be moved into the trash root inside the
> snapshottable directory.
> 2. HDFS-15539 prevents admins from disallowing snapshot if the trash root
> inside is not empty
> h2. Problem
> 1. When {{dfs.namenode.snapshot.trashroot.enabled=true}}, currently if the
> directory (to be allowed snapshot on) is an EZ root, it throws
> {{FileAlreadyExistsException}} because the trash root already exists
> (encryption zone has already created an internal trash root).
> 2. Similarly, at the moment if we disallow snapshot on an EZ root, it may
> complain that the trash root is not empty (or delete it if empty, which is
> not desired since EZ will still need it).
> h2. Solution
> 1. Let allowSnapshot succeed by not throwing {{FileAlreadyExistsException}},
> but informs the admin that the trash already exists.
> 2. Ignore {{checkTrashRootAndRemoveIfEmpty()}} check if path is EZ root.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
