[
https://issues.apache.org/jira/browse/HDFS-15696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HDFS-15696:
-------------------------
Description:
getBlockFile can return null at
https://github.com/apache/hadoop/blob/2ce2198287c9acade501d2681475fac1e5c27c68/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java#L346
all its callers have null checker except at
https://github.com/apache/hadoop/blob/2ce2198287c9acade501d2681475fac1e5c27c68/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/LocalReplica.java#L399
We shoud add null check for pontential NPE
was:
peek can return null at
[https://github.com/apache/hbase/blob/1726160839368df14602da1618e3538955b25f74/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java#L108]
all its callers have null checker except at
[https://github.com/apache/hbase/blob/1726160839368df14602da1618e3538955b25f74/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java#L110]
We shoud add null check for pontential NPE
> One pontential NPE
> ------------------
>
> Key: HDFS-15696
> URL: https://issues.apache.org/jira/browse/HDFS-15696
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: lujie
> Priority: Major
>
> getBlockFile can return null at
> https://github.com/apache/hadoop/blob/2ce2198287c9acade501d2681475fac1e5c27c68/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java#L346
>
> all its callers have null checker except at
> https://github.com/apache/hadoop/blob/2ce2198287c9acade501d2681475fac1e5c27c68/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/LocalReplica.java#L399
> We shoud add null check for pontential NPE
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
