[
https://issues.apache.org/jira/browse/HDFS-15648?focusedWorklogId=518691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518691
]
ASF GitHub Bot logged work on HDFS-15648:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/20 23:32
Start Date: 01/Dec/20 23:32
Worklog Time Spent: 10m
Work Description: iwasakims commented on a change in pull request #2501:
URL: https://github.com/apache/hadoop/pull/2501#discussion_r533793171
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileChecksum.java
##########
@@ -77,6 +81,31 @@
private String stripedFile2 = ecDir + "/stripedFileChecksum2";
private String replicatedFile = "/replicatedFileChecksum";
+ private String checksumCombineMode;
+ private boolean expectComparableStripedAndReplicatedFiles;
+ private boolean expectComparableDifferentBlockSizeReplicatedFiles;
Review comment:
I removed boolean params and updated issue/PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 518691)
Time Spent: 50m (was: 40m)
> TestFileChecksum should be parameterized
> ----------------------------------------
>
> Key: HDFS-15648
> URL: https://issues.apache.org/jira/browse/HDFS-15648
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ahmed Hussein
> Assignee: Masatake Iwasaki
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{TestFileChecksumCompositeCrc}} extends {{TestFileChecksum}} overriding 3
> methods that return a constant flag True/False.
> The class is useless and it causes confusion with two different jiras, while
> the main bug should be in TestFileChecksum.
> The {{TestFileChecksum}} should be parameterized
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
