[
https://issues.apache.org/jira/browse/HDFS-15706?focusedWorklogId=519831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-519831
]
ASF GitHub Bot logged work on HDFS-15706:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/20 19:21
Start Date: 03/Dec/20 19:21
Worklog Time Spent: 10m
Work Description: jojochuang commented on a change in pull request #2515:
URL: https://github.com/apache/hadoop/pull/2515#discussion_r535514879
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSExceptionProvider.java
##########
@@ -95,4 +99,9 @@ protected void log(Response.Status status, Throwable
throwable) {
LOG.warn("[{}:{}] response [{}] {}", method, path, status, message,
throwable);
}
+ private void logErrorFully(Response.Status status, Throwable throwable) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Failed with " + status, throwable);
Review comment:
Let's use parameterized logging, shall we?
That way, you don't need to check if debug log is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 519831)
Time Spent: 20m (was: 10m)
> HttpFS: Log more information on request failures
> ------------------------------------------------
>
> Key: HDFS-15706
> URL: https://issues.apache.org/jira/browse/HDFS-15706
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: httpfs
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [~kihwal] reported that the exception provider does not log anything for the
> requests failing with 403 or 500. This has made debugging extremely
> difficult. As more customers are using HttpFS server, this needs an
> improvement:
> * Turn on/off logging.
> * Log the full stack trace with the exception when it is on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
