[ 
https://issues.apache.org/jira/browse/HDFS-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244411#comment-17244411
 ] 

Ayush Saxena commented on HDFS-15221:
-------------------------------------

Thanx [~hadoop_yangyun] for the patch.

{code:java}
        2814          if (effectiveFs == null || effectiveFs.equals(configFs)) {
2815            LOG.error("Filesystem mismatch for storage location {}. " +
2816                "Configured is {}, effective is {}.",
2817                location.getUri(), configFs, effectiveFs);
2818            return false;
2819          }
{code}
I think the check, would be {{!effectiveFs.equals(configFs)}}, did you missed 
the {{not}}

Secondly the test isn't passing for me on MacOs, so, you need to add a 
assumeTrue, if the os is mac os.
The df parser seems to be complaining. :

{code:java}
java.io.IOException: Could not parse line: map auto_home           0    0       
  0   100%    /System/Volumes/Data/home

        at org.apache.hadoop.fs.DF.parseOutput(DF.java:195)
        at org.apache.hadoop.fs.DF.getFilesystem(DF.java:76)
        at 
org.apache.hadoop.hdfs.server.datanode.TestDataDirs.testDataDirFileSystem(TestDataDirs.java:121)
{code}




> Add checking of effective filesystem during initializing storage locations
> --------------------------------------------------------------------------
>
>                 Key: HDFS-15221
>                 URL: https://issues.apache.org/jira/browse/HDFS-15221
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Yang Yun
>            Assignee: Yang Yun
>            Priority: Minor
>         Attachments: HDFS-15221-002.patch, HDFS-15221-003.patch, 
> HDFS-15221-004.patch, HDFS-15221-005.patch, HDFS-15221-006.patch, 
> HDFS-15221-007.patch, HDFS-15221-008.patch, HDFS-15221-009.patch, 
> HDFS-15221-010.patch, HDFS-15221-011.patch, HDFS-15221.patch
>
>
> We sometimes mount different disks for different storage types as the storage 
> location. It's important to check the volume is mounted rightly before 
> initializing storage locations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to